Bugs if you use dimensions in mm
rasrenan opened this issue · comments
I have been using the panelizer.ulp version from Jan/21 with no problemas. Since I update to current version, I can't creat a panel, it crashes. It also has a bug if you choose dimensions in milimeter. Thank you in advance.
Hi @rasrenan , Sorry you are having issues with this tool. I fear that it may have been some of my updates in the past year that may be causing the crash/bug. Can you give any more information about it? At what point does it crash?
Also, I just tried using mm, and I noticed the following error window. Is this what you are seeing too?
I will dig into this asap.
Let us know and thanks!
Pete
Hi @lewispg228, thanks for the quick response!
This error reported by you is also occurring here, saying that the number of rows and columns is zero. If I ignore it and keep trying, the program crashes next.
Another bug I noticed when using the measurements in millimeters is when you click more than once on the measurement selection selector, you will notice that there is an inconsistency in the design width and height measurements presented in the setup window. I apologize for not being able to show the screenshot as I have already downgraded to the previous version.
Good news, I found the mm issue. It was missing the conversion back to inches (on width and height) before calling panelizer.
See my code tweaks here on this commit:
Please pull the latest and let us know how it goes.
Cheers!
-Pete
PS I'm not sure how to fix the second issue you are talking about, but it seems that when you click on the same unit radio button more than once, it is doing the conversion a second time... For now, please just click on it once when you first run the ULP. Thanks!