Installation issue: freetype @2.13 when build_system=cmake

[Chris Marsh]

Steps to reproduce the issue

$  spack install freetype@2.13.2 build_system=cmake

Error message

Error message

/home/chm003/project-ords/spack/stage/spack-stage-freetype-2.13.2-7zeaimhqz5vgisj7byyfqruv4rwh4u2y/spack-src/builds/unix/ftsystem.c: In function 'FT_Stream_Open':
/home/chm003/project-ords/spack/stage/spack-stage-freetype-2.13.2-7zeaimhqz5vgisj7byyfqruv4rwh4u2y/spack-src/builds/unix/ftsystem.c:258:12: warning: implicit declaration of function 'open'; did you mean 'popen'? [-Wimplicit-function-declaration]
  258 |     file = open( filepathname, O_RDONLY );
      |            ^~~~
      |            popen
/home/chm003/project-ords/spack/stage/spack-stage-freetype-2.13.2-7zeaimhqz5vgisj7byyfqruv4rwh4u2y/spack-src/builds/unix/ftsystem.c:258:32: error: 'O_RDONLY' undeclared (first use in this function)
  258 |     file = open( filepathname, O_RDONLY );
      |                                ^~~~~~~~
/home/chm003/project-ords/spack/stage/spack-stage-freetype-2.13.2-7zeaimhqz5vgisj7byyfqruv4rwh4u2y/spack-src/builds/unix/ftsystem.c:258:32: note: each undeclared identifier is reported only once for each function it appears in
/home/chm003/project-ords/spack/stage/spack-stage-freetype-2.13.2-7zeaimhqz5vgisj7byyfqruv4rwh4u2y/spack-src/builds/unix/ftsystem.c:341:22: warning: implicit declaration of function 'read'; did you mean 'fread'? [-Wimplicit-function-declaration]
  341 |         read_count = read( file,
      |                      ^~~~
      |                      fread
/home/chm003/project-ords/spack/stage/spack-stage-freetype-2.13.2-7zeaimhqz5vgisj7byyfqruv4rwh4u2y/spack-src/builds/unix/ftsystem.c:362:5: warning: implicit declaration of function 'close'; did you mean 'pclose'? [-Wimplicit-function-declaration]
  362 |     close( file );
      |     ^~~~~
      |     pclose

Information on your system

 spack debug report
* **Spack:** 0.22.0.dev0 (978c20f35ad7f1c071ee88dddd00f7a46ba13d61)
* **Python:** 3.6.8
* **Platform:** linux-rhel8-icelake
* **Concretizer:** clingo

Additional information

Maintainer: @michaelkuhn

Using cmake, 2.11 builds fine, but the newer versions added in /pull/43571 don't build for me. I see that /pull/43571 was tested against autotools.

I can find various forum posts to this over the years, and the only thing I can find is this issue
https://gitlab.freedesktop.org/freetype/freetype/-/merge_requests/48

which feels related because the freetype build is using the internal unix source tree.

spack-build-out.txt

General information

• I have run spack debug report and reported the version of Spack/Python/Platform
• I have run spack maintainers <name-of-the-package> and @mentioned any maintainers
• I have uploaded the build log and environment files
• I have searched the issues of this repo and believe this is not a duplicate