Windows support
keegancsmith opened this issue · comments
We have file path issues all over the place. We also have some in-progress work to sort this all out by @alexsaveliev. #86 #79
+1 windows support needed
👍
I see several Windows PRs merged. Is this issue still relevant?
In theory it is working, we are running a windows based CI and the tests pass. Can you try the language server out on windows and tell me if it works? I don't have access to a windows machine.
@keegancsmith This is great news. I gave this a try today from VS Code and found the below:
- Hover, Go to definition, Format, Auto-completion works
- References and Signature Help both fail with "import "/c:/GoCode/src/github.com/golang/example/hello": cannot import absolute path"
- Workspace symbol search returns empty results, no error
Repeating my comment here, I tested this using VSCode on Windows and everything worked except for Find References:
Find References works but suffers from the same problem as
guruon Windows: searching for references of a symbol at the definition site of the symbol only finds references in the same package but searching for references from a usage site of the symbol outside of its package finds all references in all packages.
FYI, I have submitted a PR fixing the Find References bug on Windows in guru that I mentioned earlier: golang/tools#56
I tried searching the go-langserver code to see if the same fix was trivially applicable but I was not successful.