Ignore unsupported texture DDS type rather than crash

Question

Ignore unsupported texture DDS type rather than crash

Grimrukh opened this issue 4 months ago · comments

Currently, DSMS crashes if it encounters a texture with a DDS type it can't read, like BC5U (even though the game may support these). It would be great if these textures could at least just be ignored. Screenshot below.

Thanks for all the hard work gang <3

Philiquaz · Answer 1 · Tue Jun 11 2024 00:41:57 GMT+0800 (China Standard Time)

Will have to take a look. This looks like one of those places that was left as "bug to fix, we want to see these errors" rather than something we quietly ignore and never hear about.

Philiquaz · Answer 2 · Wed Jun 19 2024 19:02:53 GMT+0800 (China Standard Time)

As of 1.11 should log texture errors instead of crashing. Feel free to reopen if something else goes wrong as a result.

Michael Schmidt · Answer 3 · Wed Jun 19 2024 19:03:27 GMT+0800 (China Standard Time)

@Philiquaz I believe this issue was fixed in #901.

Also, about the GetPixelFormatFromFourCC function: a few FourCC values are still missing (e.g. BC5S, which is used once in ER IIRC). I'm currently in the process of adding a new DDS decoder to a library, so feel free to copy what I do for converting FourCC to DXGI_FORMAT.

Edit: Damn, seconds too late :)