fillLivestreamResponse の N+1

[Ryoga]

for ループの中で fillLivestreamResponse が呼ばれているので実質的に N+1 になっていそう

isucon13/go/livestream_handler.go

Lines 224 to 231 in d3066fd

 livestreams := make([]Livestream, len(livestreamModels)) 
 for i := range livestreamModels { 
 	livestream, err := fillLivestreamResponse(ctx, tx, *livestreamModels[i]) 
 	if err != nil { 
 		return echo.NewHTTPError(http.StatusInternalServerError, "failed to fill livestream: "+err.Error()) 
 	} 
 	livestreams[i] = livestream 
 } 

isucon13/go/livestream_handler.go

Lines 261 to 268 in d3066fd

 livestreams := make([]Livestream, len(livestreamModels)) 
 for i := range livestreamModels { 
 	livestream, err := fillLivestreamResponse(ctx, tx, *livestreamModels[i]) 
 	if err != nil { 
 		return echo.NewHTTPError(http.StatusInternalServerError, "failed to fill livestream: "+err.Error()) 
 	} 
 	livestreams[i] = livestream 
 } 

isucon13/go/livestream_handler.go

Lines 304 to 311 in d3066fd

 livestreams := make([]Livestream, len(livestreamModels)) 
 for i := range livestreamModels { 
 	livestream, err := fillLivestreamResponse(ctx, tx, *livestreamModels[i]) 
 	if err != nil { 
 		return echo.NewHTTPError(http.StatusInternalServerError, "failed to fill livestream: "+err.Error()) 
 	} 
 	livestreams[i] = livestream 
 }