Giters

sophiajt / jaktnesmonster

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Issues with ADC code

haakonnessjoen opened this issue · comments

commented

https://github.com/jntrnr/jaktnesmonster/blob/1d7b616a50ba78369e73afdc91de4265c42ebc97/src/cpu.jakt#L420

The first issue is that the cast to u16 crashes if the intermediate value is negative. I asked on the jakt repo, and it seems like this is expected behaviour when using "as!" between incompatible types.

Second issue is that .a is not being set ;)