Trailing punctuation on GitHub URLs isn't ignored

Question

Trailing punctuation on GitHub URLs isn't ignored

dgw opened this issue 6 years ago · comments

If someone posts a GitHub URL that should be recognized and processed, e.g. https://github.com/sopel-irc/sopel-github/issues/7, but it is followed by punctuation (like ,), the plugin will not process it.

URL parsing, and deciding when punctuation should be included as part of a URL especially, is a giant can of worms. This isn't the end of the world (users will learn not to put punctuation right at the end of a URL), but ideally it wouldn't be an issue. Notably, my IRC client (The Lounge) recognizes that , isn't part of the URL in this case.

dgw · Answer 1 · Tue Mar 26 2019 21:46:24 GMT+0800 (China Standard Time)

This should be fixed by sopel-irc/sopel#1510

dgw · Answer 2 · Wed Jul 31 2019 04:49:27 GMT+0800 (China Standard Time)

Hasty close. We still need to update this for the modern Sopel URL handling.