flowfunc/Transfer uses == instead of equals(..)

Question

flowfunc/Transfer uses == instead of equals(..)

tim-hoffman opened this issue 7 years ago · comments

commit 19cb6fb fixed the same issue in flowfunc/Kill but use of == remains in the Transfer class.

The same usage also exists in flowfunc/Gen but shouldn't cause any issues there if IFDSTabulationProblem#zeroValue() is always used to obtain the unique instance of zero.

Eric Bodden · Answer 1 · Thu Oct 12 2017 15:55:58 GMT+0800 (China Standard Time)

Thanks! Would you like to provide a pull request for this? I think then we should fix it in Gen, too. (it should not hurt doing so)

Timothy Hoffman · Answer 2 · Fri Oct 13 2017 03:14:51 GMT+0800 (China Standard Time)

I performed the replacement of == with equals(..) in both Transfer and Gen and created a pull request.