Liip imagine integration and svg

Question

Liip imagine integration and svg

dima-gr opened this issue 3 years ago · comments

If you enable integration with liip imagine, svg image downloaded and render in admin list but when you try render image somewhere in twig template then svg not rendered, maybe you don't need to apply the filter for them

Christian Gripp · Answer 1 · Mon Nov 29 2021 17:06:52 GMT+0800 (China Standard Time)

Can you provide a PR with this feature @dima-gr ?

dima-gr · Answer 2 · Mon Nov 29 2021 17:22:52 GMT+0800 (China Standard Time)

Ok, but it will be littlebit later

Vincent Langlet · Answer 3 · Fri Apr 01 2022 04:07:10 GMT+0800 (China Standard Time)

Friendly ping @dima-gr, do you have some time for this feature ?

dima-gr · Answer 4 · Fri Apr 01 2022 05:07:05 GMT+0800 (China Standard Time)

I'll try provide a PR in the next week

dima-gr · Answer 5 · Wed Apr 06 2022 17:51:08 GMT+0800 (China Standard Time)

I'm create PR, the problem is that the GD driver does not support working with svg, the entry is marked as MediaInterface::STATUS_ERROR, it happens in ImageProvider.php on 283 line

        try {
            $image = $this->imagineAdapter->open($binaryContent->getPathname());
        } catch (\RuntimeException $e) {
            $media->setProviderStatus(MediaInterface::STATUS_ERROR);

            return;
        }

github-actions · Answer 6 · Mon Oct 03 2022 18:04:11 GMT+0800 (China Standard Time)

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · Answer 7 · Sat Apr 08 2023 22:02:46 GMT+0800 (China Standard Time)

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.