Deprecate this bundle

Question

Deprecate this bundle

core23 opened this issue 4 years ago · comments

Christian Gripp commented 4 years ago

Feature Request

There is no need for the bundle anymore. Symfony / PSR cache is more common. Even doctrine dropped their custom cache.

Grégoire Paris commented 4 years ago

Done

Grégoire Paris · Answer 1 · Tue Feb 11 2020 05:14:14 GMT+0800 (China Standard Time)

Even doctrine dropped there custom cache.

trying to, but not there yet I'm afraid :P

Vincent Langlet · Answer 2 · Mon Mar 09 2020 07:59:53 GMT+0800 (China Standard Time)

Let's start with the README #289

I don't have the right to edit the description and add [deprecated] like other packages

Christian Gripp · Answer 3 · Mon Mar 09 2020 15:09:56 GMT+0800 (China Standard Time)

@greg0ire @OskarStark can you do this?

Grégoire Paris · Answer 4 · Mon Mar 16 2020 04:14:02 GMT+0800 (China Standard Time)

I'm wondering if it's not a bit premature… I mean we have lots of bundles relying on the cache bundle, shouldn't we move them to something else first?

Grégoire Paris · Answer 5 · Mon Mar 16 2020 04:59:46 GMT+0800 (China Standard Time)

It's not like the package is abandoned or triggering deprecations though 🤔
What do we mean exactly by deprecating? Asking because of sonata-project/dev-kit#617
Will we refuse any PRs ? Should we stop getting improvements from dev-kit?

Vincent Langlet · Answer 6 · Mon Mar 16 2020 05:28:44 GMT+0800 (China Standard Time)

IMO, we're just deprecating the package. Which means we're not recommending the usage of it, and recommend to use something else instead.

When we're deprecating something in a bundle,

First we trigger a deprecation message
Second we're fixing the deprecation in others bundle
Third we're removing it

Adding [deprecated] is like the step one.

Grégoire Paris · Answer 7 · Mon Mar 16 2020 05:34:15 GMT+0800 (China Standard Time)

Should we stop getting improvements from dev-kit?

And this sounds like step 3

Vincent Langlet · Answer 8 · Mon Mar 16 2020 05:41:38 GMT+0800 (China Standard Time)

Should we stop getting improvements from dev-kit?

And this sounds like step 3

I don't really know what is doing the dev-kit.
@core23 Asked me a PR, so I copied the coreBundle one
sonata-project/dev-kit@85390bb#diff-70800a36c38d85e21390f3af255c8420

And the "step 2" is still not finished for the core-bundle.

So I can't say if we should revert these pr or not.
But if these PR shouldn't be made for Cache/Intl/EasyExtend in the devkit, it should not have been done for the CoreBundle too.

Grégoire Paris · Answer 9 · Mon Mar 16 2020 05:46:11 GMT+0800 (China Standard Time)

I guess this must be in order to avoid extra work when a dev-kit PR does not apply cleanly to one of these bundles. I will merge the cache PR and deploy, this is probably fine 🤞

Christian Gripp · Answer 10 · Mon Mar 16 2020 07:34:48 GMT+0800 (China Standard Time)

We should also add a new abandoned entry to the composer.json file

Grégoire Paris · Answer 11 · Mon Mar 16 2020 14:55:44 GMT+0800 (China Standard Time)

Wouldn't this trigger warnings for people using our other packages, like the block bundle?

Christian Gripp · Answer 12 · Mon Mar 16 2020 16:03:45 GMT+0800 (China Standard Time)

That's right but okay. We deprecated the bundle on GitHub, so we should deprecate the bundle everywhere

Jordi Sala Morales · Answer 13 · Thu Dec 09 2021 23:42:25 GMT+0800 (China Standard Time)

This issue should be closed and instead one on PageBundle might be opened to track the efforts of remove this deprecated bundle from there.