solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy

Home Page:https://docs.solo.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Headers to add keys are not validated

davidjumani opened this issue · comments

Gloo Edge Product

Open Source

Gloo Edge Version

All

Kubernetes Version

All

Describe the bug

vs.yaml

        headerManipulation:
          requestHeadersToAdd:
          - header:
              key: "head(er)"
              value: random

Previously

$ kg apply -f vs.yaml 

virtualservice.gateway.solo.io/default created

$ curl localhost:8080/get
invalid header name: head(er)

Expected Behavior

It should not accept invalid header keys

Steps to reproduce the bug

As above

Additional Environment Detail

No response

Additional Context

No response

This is fixed in OSS 1.17.0 and 1.16.16 when released and Enterprise 1.17.0 and 1.16.11 when released