Giters

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy

Home Page:https://docs.solo.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Allow customizing the command in the lifecycle preStop hook via helm chart

sadieleob opened this issue · comments

commented

Gloo Edge Product

Enterprise

Gloo Edge Version

1.16.3

Is your feature request related to a problem? Please describe.

To enable the lifecycle hook in GE helm-chart we have gracefulShudown , enabling it in the helmCharts configures the following in the gateway-proxy deployment:

lifecycle:                                                                                                                                                                                                                        
    preStop:                                                                                                                                                                                                                         
        exec:                                                                                                                                                                                                                         
            command:                                                                                                                                                                                                                    
            - /bin/sh                                                                                                                                                                                                                   
            - -c                                                                                                                                                                                                                         
            - wget --post-data "" -O /dev/null 127.0.0.1:19000/healthcheck/fail; sleep                                                                                                                                                  
               15

The ask is to be able to customize the command via helm values.

Describe the solution you'd like

Allowing the customization of the command in the lifecycle preStop hook

Describe alternatives you've considered

The alternative is to use Kustomize or edit the deployment directly

Additional Context

No response

commented

Zendesk ticket #3517 has been linked to this issue.