solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy

Home Page:https://docs.solo.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Published glooctl binaries are not the format advertised

jbohanon opened this issue · comments

Gloo Edge Product

Open Source

Gloo Edge Version

v1.16.0

Kubernetes Version

all

Describe the bug

glooctl binaries are not built in the various ways advertised.

from the build logs:

GO111MODULE=on CGO_ENABLED=0 GOARCH=amd64 GOOS=linux go build -ldflags="-X github.com/solo-io/gloo/pkg/version.Version=1.16.9" -gcflags=all="-N -l" -o /workspace/gloo/_output/glooctl-linux-amd64 projects/gloo/cli/cmd/main.go 
GO111MODULE=on CGO_ENABLED=0 GOARCH=amd64 GOOS=linux go build -ldflags="-X github.com/solo-io/gloo/pkg/version.Version=1.16.9" -gcflags=all="-N -l" -o /workspace/gloo/_output/glooctl-linux-arm64 projects/gloo/cli/cmd/main.go 
GO111MODULE=on CGO_ENABLED=0 GOARCH=amd64 GOOS=darwin go build -ldflags="-X github.com/solo-io/gloo/pkg/version.Version=1.16.9" -gcflags=all="-N -l" -o /workspace/gloo/_output/glooctl-darwin-amd64 projects/gloo/cli/cmd/main.go 
GO111MODULE=on CGO_ENABLED=0 GOARCH=amd64 GOOS=darwin go build -ldflags="-X github.com/solo-io/gloo/pkg/version.Version=1.16.9" -gcflags=all="-N -l" -o /workspace/gloo/_output/glooctl-darwin-arm64 projects/gloo/cli/cmd/main.go 
GO111MODULE=on CGO_ENABLED=0 GOARCH=amd64 GOOS=windows go build -ldflags="-X github.com/solo-io/gloo/pkg/version.Version=1.16.9" -gcflags=all="-N -l" -o /workspace/gloo/_output/glooctl-windows-amd64.exe projects/gloo/cli/cmd/main.go 
VERSION=1.16.9 GO111MODULE=on go run ci/upload_github_release_assets.go true

Expected Behavior

glooctl binaries are the correct format

Steps to reproduce the bug

  1. curl -Lo $HOME/Downloads/glooctl-darwin-arm64 https://github.com/solo-io/gloo/releases/download/v1.16.9/glooctl-darwin-arm64
  2. file $HOME/Downloads/glooctl-darwin-arm64
$ file ~/Downloads/glooctl-darwin-arm64
/home/jacob/Downloads/glooctl-darwin-arm64: Mach-O 64-bit x86_64 executable

Additional Environment Detail

No response

Additional Context

No response