Features wanted? (hcloud-cloud-controller-manager, CSI driver, firewalls)
anon6789 opened this issue · comments
Hi,
I tried the the terraform project to setup a cluster in the Hetzner cloud. It works quite well, thank you.
However I added some more features in my fork. For example
- hcloud csi driver
- hcloud-cloud-controller-manager
- rudimentary firewall rules
- some more variables (like datacenter location and pod/node cidr)
- version bumps to kubernetes, docker, ubuntu and calico
Do you want any of these changes as a PR in this project?
Greetings
Hey @anon6789 ,
thanks for asking this question. I would really appreciate to get more features in it 💯 👍 . It's semantic versioned so I got no problems to add more features and bump versions. I would really appreciate small pull requests that are fast reviewable and independent from other features.
Hey @solidnerd @anon6789 I've added these features to my fork https://github.com/aslubsky/terraform-k8s-hcloud
But I not sure that I can make PR, because it has some different structure, see my explanations in https://alexslubsky.medium.com/setup-highly-available-kubernetus-cluster-with-hetzner-cloud-and-terraform-941a9e25ddf6?source=friends_link&sk=a6555b9dd2c28a21f1d99dd1592f6e63
If you have any ideas on how to merge this, pls share, I'll prepare PR in that way
Hey @aslubsky,
Thanks for sharing your awesome blog post 👍 💯 . I had some thoughts around my head about how we can integrate this in a good manner. I think we should add separate issues for tracking all those activities.
- Add better CI & maintenance support (@solidnerd)
- move from circle-ci to GitHub actions
- Introduce Pre-Commit Hooks
- Terraform docs
- Merge CSI Driver from @anon6789 to the main repo (@solidnerd)
- Add a submodule for hcloud loadbalacner LoadBalancer Support
loadbalancer
(@aslubsky)- A reference can be found here terraform-aws-rds/modules
- Add a submodule for hcloud Network support
network
(@aslubsky)hcloud_network
hcloud_network_subnet
- A reference can be found here terraform-aws-rds/modules
- Check for New Kubernetes and Ubuntu Version
- Terraform Bump > 0.13
- Let's see if we can test directly terraform 0.14
- Create an examples directory (@aslubsky)
- This can contain your demo-app if you want to contribute to that
- Also, a
main.tf
that is referencing to the main module as a reference you can look here: terraform-aws-rds/examples/complete-progres
After adding those changes above, release a new module version of 2.0.0
For better Tracking, we should create separate issues and PR's.
@aslubsky I would review then your changes, and we can keep the discussion in the Pull Request's
@solidnerd I'm in )) But I'm not 'true' DevOps and may do some things not very well
So let's learn together we will see how it goes ;)