returning 1 when should not.

[bryan rasmussen]

this bs(["a","b","cde","f"],"wtf") returns 1.
this
bs([1,2,3,4],"wtf");
also returns 1.
obviously the second one is a data type problem, probably should just check to see that it is the same data type coming in and fail if not.

The first one I suppose is that an array of sorted numerical datatypes are expected, but that seems messed up since binary search can be used with sorted string arrays also.

[Ryan Day]

its been a while but i think you need to pass in your own comparator to handle string values/mixed type values.
ill take a look though =)

[bryan rasmussen]

hi, you're right of course, but I think there should be some sort of
warning popping up. especially in cases of type mismatch.

I did get it working with my own comparator.

Thanks,
Bryan Rasmussen

On Wed, Mar 9, 2016 at 2:26 PM, Ryan Day [e-mail] wrote:

its been a while but i think you need to pass in your own comparator to
handle string values/mixed type values.
ill take a look though =)

—
Reply to this email directly or view it on GitHub
#6 (comment)
.

[Ryan Day]

i decided to add support for mixed types in the default comparator. ill bump the major version just in case as it might break folks.

[Ryan Day]

published as version v1.0.0 added test in test/strings.js