sogou / SogouMRCToolkit

This toolkit was designed for the fast and efficient development of modern machine comprehension models, including both published models and original prototypes.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

several minor errors of Trainer

threefoldo opened this issue · comments

This framework is handy, I like it. Here are several problems I found:

  1. Trainer._evaluate requires 'model_path', but BaseModel doesn't provide that parameter;

  2. Trainer._inference call Trainer.inference (with 3 parameters) which doesn't exists.

Also, the default logging level disable all training information, that's inconvenient. At the end of training, there is no information of training at all.

commented

Thanks for pointing out these bugs, 1&2 should be a version problem, will fix that soon

Currently we enable the logging information by adding

logging.getLogger().setLevel(logging.INFO)
os.environ["TF_CPP_MIN_LOG_LEVEL"] = "3"

Thanks.