softprops / action-gh-release

📦 :octocat: GitHub Action for creating GitHub Releases

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Even with "draft: false", drafts get made

probonopd opened this issue · comments

I am using this:

    - name: Upload Artifacts to GitHub Releases
      uses: softprops/action-gh-release@v1
      with:
        files: |
          build/attrutil
        tag_name: continuous
        target_commitish: ${{ github.sha }}
        draft: false

https://github.com/probonopd/attrutil/blob/main/.github/workflows/build.yml

I was hoping that thanks to draft: false, the releases would not be created as drafts, but they are.

I suppose that there's Github's "boo is not bool"-problem. Try to use strings like 'false'
or if you really need bool - pass empty string "" or ${{ null }}, so it casts to boolean as false.

Thanks @boozook. Is this a change @softprops would need to make in this action, or should it work if I simply set draft: ${{ null }} instead of draft: false?

@probonopd, looking at that line I suppose the value is interpreting as following:

  • true if value == "true" (string)
  • false (actually undefined, sic!) for any other value.

Also there input is defined as empty by default.

So in this case for false I could try ${{ null }} or empty string as by default.

Anyway, it's just my suppose, I'm not sure and I'm not a guru of this language.

FYI: As I remember "false" casts to bool as true because in bytes this isn't empty or zero.
For example "0" == false => true.