soffes / sstoolkit

A collection of well-documented iOS classes for making life easier

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

warning on missing [super dealloc]

fictorial opened this issue · comments

in a bunch of places...

e.g. SSAddressBarTextField.m

- (void)dealloc {
    self.reloadButton = nil;
    self.stopButton = nil;
// >>>> why no [super dealloc] here?
}

These files don't appear to use ARC so I was kind of surprised to not see the [super dealloc].

What am I missing? Thanks!

Everything is ARC and [super dealloc] is automatically added by the compiler.

On May 25, 2012, at 9:02 PM, Brian Hammondreply@reply.github.com wrote:

in a bunch of places...

e.g. SSAddressBarTextField.m

- (void)dealloc {
   self.reloadButton = nil;
   self.stopButton = nil;
// >>>> why no [super dealloc] here?
}

These files don't appear to use ARC so I was kind of surprised to get these warnings.

What am I missing? Thanks!


Reply to this email directly or view it on GitHub:
https://github.com/samsoffes/sstoolkit/issues/122

Hmm... In SSAddressBarTextField some of the properties are 'retain' not 'strong'. Also, I was trying to use SSToolkit via CocoaPods and that was not compiling the SSToolkit files with ARC... Problem with the podspec?

Strong and retain are synonymous. They should be strong but that doesn't matter. Sounds like an issue with the podspec. If you get it sorted out, I'd love a pull request.

On May 25, 2012, at 10:01 PM, Brian Hammondreply@reply.github.com wrote:

Hmm... In SSAddressBarTextField some of the properties are 'retain' not 'strong'. Also, I was trying to use SSToolkit via CocoaPods and that was not compiling the SSToolkit files with ARC... Problem with the podspec?


Reply to this email directly or view it on GitHub:
https://github.com/samsoffes/sstoolkit/issues/122#issuecomment-5944436

Indeed they are synonymous. I saw the 'retain' and your 1.2 milestone to add ARC and assumed this toolkit wasn't ARC yet and I was somehow missing what was up with the missing dealloc calls. I bet you just need to add

s.requires_arc = true