socketsupply / union-app-studio

Like Codepen, but for native apps!

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

On Windows 10 clicking the exit button does not close the app.

kaseyhinton opened this issue · comments

On Windows 10 trying to exit the app does not work. I had to manually kill the process to exit.

When I ran it locally if i commented out these 3 lines of code in /src/index.js it functions as normal.
It looks like the global.quitting variable is undefined when is gets to onbeforeunload.

window.onbeforeunload = function (e) {
  if (!remote.getGlobal('quitting')) return false
}

trying to quit (by clicking X) both the app and the document window doesn't work on MacOS High Sierra 10.13.2

@kaseyhinton this is a dupe of #7. I've never run it on Windows. But a PR would be welcome. It should be trivial.

@asapzacy this behavior is intended. Neither can exist without the other, closing one would break the other. Can you outline a more reasonable expectation for the behavior? I'm open to improving it.

@0x00A Could you minimize the Document Window and keep the editor open?

edit -- nevermind, saw 516f639 👍