Windows build

Question

Windows build

db4 opened this issue 6 years ago · comments

Dmitry Bely commented 6 years ago

Did you ever try to build it with Visual Studio? I have numerous problems there.

Lewis Sobotkiewicz · Answer 1 · Sat Apr 21 2018 05:05:43 GMT+0800 (China Standard Time)

Unfortunately I haven't tried building on Windows. That's a missing piece for all of my Conan packages.

Dmitry Bely · Answer 2 · Sat Apr 21 2018 18:24:44 GMT+0800 (China Standard Time)

I have made a fork and fixed all issues there. I you find it useful I can submit PR to your repo.

Lewis Sobotkiewicz · Answer 3 · Thu Apr 26 2018 04:21:36 GMT+0800 (China Standard Time)

I'd very much appreciate a PR! Thanks for doing that work!

Dmitry Bely · Answer 4 · Thu Apr 26 2018 14:57:29 GMT+0800 (China Standard Time)

Done: #2

Are you planning to contribute the package to conan-center?

Lewis Sobotkiewicz · Answer 5 · Fri Apr 27 2018 02:27:46 GMT+0800 (China Standard Time)

I'll certainly contribute to conan-center if this recipe is up to their quality standards. Do you think I should submit? I can't guarantee I'll be a reliable maintainer, unfortunately :(

Dmitry Bely · Answer 6 · Fri Apr 27 2018 14:47:22 GMT+0800 (China Standard Time)

I believe the recipe is currently good enough. All major OSes/architectures are supported, CI status is green, not much maintenance is expected. I think you definitely should. Maybe just add Appveyor status like I did in my README.md?

I also have a companion recipe for SimpleAmqpClient library, created by the same author as rabbitmq-c. If rabbitmq-c is accepted by conan-center, I will submit my recipe as well.