soasme / nim-markdown

A Beautiful Markdown Parser in the Nim World.

Home Page:https://www.soasme.com/nim-markdown/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Exported `toSeq` in this package robbed me of 3 hours of my life

cmd410 opened this issue · comments

commented

proc toSeq*(tokens: DoublyLinkedList[Token]): seq[Token] =

Please, don't export toSeq proc. I've wasted a lot of time debugging why my toSeq wasn't working.
It turns out, it's due to this issue: nim-lang/RFCs#512

I've found a somewhat dirty trick to ease the pain

import markdown except toSeq

Which is fine, but would be better if wasn't exported in the first place. Is there any particular reason for this toSeq to be exposed?

commented

@cmd410 I'll patch the code and make a new release shortly. Thank you for reporting the issue.