Giters

snok / django-guid

Inject an ID into every log message from a Django request. ASGI compatible, integrates with Sentry, and works with Celery

Home Page:https://django-guid.readthedocs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Flask support

sondrelg opened this issue · comments

commented

I haven't touched Flask in a while, but I suspect django-guid is compatible with Flask, either out of the box, or with some simple modifications. I suggest we investigate what it would take to integrate with Flask, and add Flask-setup-docs.

commented

I wonder if Flask support would maybe be better as a fork that follows upstream closely?

commented

Yeah, a fork would probably be the way to go. With ASGI becoming more and more popular I'm not sure how Flask will end up in the race either. I have no personal interest in Flask, but when #22 is solved I'd probably be up to look into porting it into Starlette or similar frameworks.

commented

I’ll close this issue. Flask has signals so a fork and swap out Django logic is probably the way to go, but probably don’t belong in this package.