Bad practices with peak merging
jmorim opened this issue · comments
morimoto commented
This has always bothered me in the vignette. These are two distinct chromatographic peaks that happen to share an m/z, so probably isomers. Why does the vignette suggest merging the two peaks?
Johannes Rainer commented
that's a fair comment. this is just an example to show how such peaks could be joined, we don't say the should be. This is just to illustrate the effect of the minProp
parameter. I will update the vignette to make it more clear.
Johannes Rainer commented
I've updated the description in the vignette now. Thanks for the feedback!
Feel free to reopen the issue if further changes are necessary