Support custom Mint transports

Question

Support custom Mint transports

dannote opened this issue 3 years ago · comments

Hi!

Mint natively (and silently) supports custom transports by accepting a module implementing Mint.Core.Transport behaviour:

Mint.HTTP.connect(My.Custom.Module, "example.com", 80)

Although it's an undocumented (yet) feature, it works seamlessly. It would be great if Finch pools also accepted a tuple in the form of {module, host, port}. I saw the ongoing conversation about the UNIX socket (#139); this might be related.

Chris Keathley · Answer 1 · Tue Jun 22 2021 21:59:07 GMT+0800 (China Standard Time)

@dannote Agreed, I think we should be able to solve both of these cases with the same solution.

nico piderman · Answer 2 · Thu Jul 01 2021 01:32:04 GMT+0800 (China Standard Time)

Custom transports are not officially supported by Mint so I am not sure that we should try to add this feature that depends on a private API, see: elixir-mint/mint#323

Chris Keathley · Answer 3 · Thu Jul 01 2021 03:58:55 GMT+0800 (China Standard Time)

Oh good call @sneako. I hadn't realized that was private. Agreed that we shouldn't support a feature that is based on Mint's private API.