Update mf2py (waiting for next release)
sknebel opened this issue · comments
Exciting new features! E.g. improved implied name handling, which keeps cropping up. (e.g. http://twtr.io/1eNFR0C3voG )
yes! this should fix or at least help with snarfed/granary#145 and snarfed/granary#142 too.
bridgy is pretty particular about mf2py's behavior, and some new changes are nontrivial, eg it adds img URLs to implied names in some (all?) cases, so this will take more work than just bumping the version. still, definitely worthwhile!
the img URL thing did turn out to be a dealbreaker for mf2py 1.1.0. details in microformats/microformats2-parsing#35 .
the good news is, it sounds like everyone agrees that we should revert that part of the spec, so hopefully I'll be able to upgrade to the next mf2py release!
woo, thanks to @kartikprabhu for implementing the implied name change! microformats/mf2py@71997eb. can't wait for the next release!
deployed this just now with https://github.com/snarfed/mf2py/tree/all , which has a number of pending mf2py bug fixes, eg microformats/mf2py#115 and microformats/mf2py#118. 🤞
rolling back, it's currently crashing on microformats/mf2py#108 . e.g. https://brid.gy/log?start_time=1532441945&key=aglzfmJyaWQtZ3lyFgsSB1R3aXR0ZXIiCXNjaHVzc21hbgw
added microformats/mf2py#114 and it's no longer crashing. mf2py at head (with a bunch more unmerged bug fixes) is now live on bridgy prod.
closing, yay. thanks again @sknebel!