smyte / ratelimit

Smyte's high-performance rate limiter

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Build failed: ERROR: cpp-build/WORKSPACE:214:1: in bind rule //external:gtest: non-test target '//external:gtest' depends on testonly target '@gtest_archive//:gtest' and doesn't have testonly attribute set.

dbigunyak opened this issue · comments

can't build ratelimit:

# git log -1
commit c3e45f7d0e6d5b4ed932f1cf502e2b20b825ccae
Merge: d077e2b d1ddda0
Author: Pete Hunt <pete@smyte.com>
Date:   Fri Nov 4 20:08:38 2016 +0000

    Merge branch 'reposync-github/cpp-build' of /home/pete/authbox
# bazel build -c opt ratelimit
Extracting Bazel installation...
..............
ERROR: /v2/tmp/cpp-build/WORKSPACE:214:1: in bind rule //external:gtest: non-test target '//external:gtest' depends on testonly target '@gtest_archive//:gtest' and doesn't have testonly attribute set.
ERROR: Analysis of target '//ratelimit:ratelimit' failed; build aborted.
INFO: Elapsed time: 67.532s

https://github.com/chronos-tachyon/googletest-bazel became testonly, I remove testonly definition for package at bazel cache, so it statr build, but I don't think it's very nice solution :)

@dbigunyak the latest bazel 0.4 has a breaking change. We have updated the repos to fix this issue by removing testonly from gtest. It's not a very nice solution, but it gets the job done for now. We will play with the latest bazel to figure out a permanent solution.