smugmug / yui-gallery

SmugMug YUI gallery components.

Home Page:http://smugmug.github.io/yui-gallery/api/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Menus should not take up space (causing scroll bars) when they're hidden

BenNG opened this issue · comments

Hi !

We are using the sm-menu in production and we saw an interesting thing.
When using the menu with a lot of items, the scrollbar appears when the menu is displayed.
Once we click on an item or click outside, the menu is only hidden and the scrollbar stays visible.

As only the position is important, the width and height could be both set to 1px when the menu is hidden.
What do you think ?

http://jsbin.com/iforun/8/edit

Good idea. And thanks for the repro case!

In the long-term, I'd like to implement in-menu scrolling for very long menus, but in the short term I'll make sure long menus at least don't take up any space when they're hidden.

You are welcome.
Do you know if your menu will be integrated in the core lib ?
Thank you !

There are no plans that I'm aware of.

Ok
Thanks