Not able to scroll a long modal
midnightcodr opened this issue · comments
🐛 Bug Report
A clear and concise description of what the bug is.
https://wkx04p7yp8.codesandbox.io/
To Reproduce
Please go to https://wkx04p7yp8.codesandbox.io/, switch to mobile mode, then try to scroll the content using a pointer device (it will be a user's finger for a real mobile device), you will find that scrolling is impossible using a pointer device with two exceptions:
- you can only scroll using a browser's vertical scroll bar
- you can scroll using a keyboard's up and down keys
Neither of which is possible using a mobile device. I've tested this URL using a real phone.
Expected behavior
Scrolling should work with a pointer device.
Link to repl or repo (highly encouraged)
Never mind, I was not using the data type for attribute overflow. Fixed.
Actually it is a true bug, visible in documentation. I think it is relative to scroll blocking, cc @theKashey.
Yeah. It’s partially my fault. Lock should allow some move if target is greater than parent. Just a few lines no fix in conditions.
Could be easily fixed with a proper overflow, but better to be solved on a lover level
There was a mistake in scroll possibility calculations, which led to a false negative in case of smooth-ui.
Please update react-remove-scroll - just remove it from yarn.lock or package.lock and reinstall packages - https://codesandbox.io/s/6jqlqwmllk
Modal is gone in new release, please use Reakit Dialog instead.