Manual build script appears broken under Fedora 31, Ubuntu 19.04, 20.04.

Question

Manual build script appears broken under Fedora 31, Ubuntu 19.04, 20.04.

jriehl opened this issue 4 years ago · comments

Describe the bug
Running the build script errors out with the following message:

ninja: build stopped: subcommand failed.
CMake Error at CMakeLists.txt:51 (message):
  Build step for deps-build failed: 1


-- Configuring incomplete, errors occurred!
See also "/root/smf/build/release/CMakeFiles/CMakeOutput.log".

I get this not just on Ubuntu 19.04, but also Ubuntu 20.04, and Fedora 31.

To Reproduce
Steps to reproduce the behavior:

docker run -it ubuntu:disco
apt update -y && apt upgrade -y
apt install git
git clone https://github.com/smfrpc/smf.git
cd smf
./install-deps.sh
./tools/build.sh -r
Build fails per text above.

Expected behavior
I expected a successful release build.

Environment Info

Ubuntu 19.04, 20.04, and Fedora 31 running in Docker containers
On current master branch.
GCC 8 and 9

Alexander Gallego · Answer 1 · Thu Feb 13 2020 13:55:15 GMT+0800 (China Standard Time)

Hi Jon, thanks for bringing this up. I haven't updated this repo in a littlebit. I'll sync up seastar and push the fixes for it soon. Let me know if you want to push a fix for it too.

Thanks for reporting.

Alexander Gallego · Answer 2 · Thu Feb 13 2020 13:55:50 GMT+0800 (China Standard Time)

/cc @ivotron maybe we also host this in vectorizedio pipeline? just a thought.

Jon Riehl · Answer 3 · Fri Feb 14 2020 03:30:18 GMT+0800 (China Standard Time)

I'd be glad to help if you could provide some pointers. One of the frustrating things I found while hacking on this, was the actual error is buried deep in the console output. Even then, it wasn't obvious to me what exactly blew up.

Alexander Gallego · Answer 4 · Fri Feb 14 2020 14:16:28 GMT+0800 (China Standard Time)

my hunch is that we are pulling in some old seastar lib and we haven't updated the compiler & libs to include the latest seastar fixes. this repo has been frozen for a few months.

Alexander Gallego · Answer 5 · Fri Feb 14 2020 14:16:42 GMT+0800 (China Standard Time)

Let me try to push a fix for this tom

Alexander Gallego · Answer 6 · Mon Feb 17 2020 01:12:23 GMT+0800 (China Standard Time)

Taking a look at this today. Can you post the full cmake error log.

Alexander Gallego · Answer 7 · Mon Feb 17 2020 14:02:12 GMT+0800 (China Standard Time)

i tried testing today but f31 upgraded to cgroups2 and docker-ce wasn't starting. if you can upload the full log, I'll try to debug it @jriehl

Jon Riehl · Answer 8 · Tue Feb 18 2020 04:28:34 GMT+0800 (China Standard Time)

Here's the output from both ninja (by way of the build script) and cmake:
build.sh.out.gz
CMakeOutput.log.gz

Alexander Gallego · Answer 9 · Tue Feb 18 2020 11:09:44 GMT+0800 (China Standard Time)

perf thanks. looking

Alexander Gallego · Answer 10 · Tue Feb 18 2020 11:17:34 GMT+0800 (China Standard Time)

ok can reproduce with podman run -it ubuntu:disco seeing the deps, they haven't been updated here in a while.

that's basically the issue. seastar and dpdk have advanced. I'm gna sync w/ upstream

Alexander Gallego · Answer 11 · Wed Feb 19 2020 04:48:00 GMT+0800 (China Standard Time)

ok i looked into this a little bit. looks like some deps are just old and need to be updated.

Currently the build is very close to being 100% reproducible, but due to my lack of time, I might switch it to the packages maintained by each operating system (apt-get and dnf-install)

What we do today is we build each (almost all) transitive packages from source at known checksums so we have confidence in what we build, but this requires a ton of maintiner's time I'm lacking these days.

I'll try to take another hr later today on this.