install-deps.sh should not change the system compiler on Ubuntu 16.04

Question

install-deps.sh should not change the system compiler on Ubuntu 16.04

nacl opened this issue 5 years ago · comments

Describe the bug
On Ubuntu 16.04 install-deps.sh script changes the default system compiler in the alternatives database. This is not expected behavior for a dependency installation script, which should only make the software available, not change any other system configuration.

The script also clobbers sections of the the alternatives database, which makes it difficult to restore the original system state. The changes to the alternatives database are a bit heavy-handed, and should be made more refined.

To Reproduce
Steps to reproduce the behavior:

Invoke install-deps.sh as root
gcc -version identifies itself as gcc-8, despite it being gcc-5 earlier.

Expected behavior

gcc -version to identify itself as whatever the user previously had set. The alternatives list should also not be modified.

Environment Info

Ubuntu 16.04
git b052af2 (although the offending code is still present)

Alexander Gallego · Answer 1 · Wed Mar 13 2019 04:10:38 GMT+0800 (China Standard Time)

That's a fair request. We'll fix it. We need it for our CI. So we just need to test if the CI variable is set.

Alexander Gallego · Answer 2 · Wed Mar 13 2019 04:13:34 GMT+0800 (China Standard Time)

We should also test for cmake version in ubuntu::Xenial just in case it is also installed out of band with this fix.

Alexander Gallego · Answer 3 · Thu Mar 14 2019 00:30:38 GMT+0800 (China Standard Time)

@nacl should be up on the latest revision.