possibly revert https://github.com/smfrpc/smf/pull/287

Question

emaxerrno opened this issue 6 years ago · comments

we should keep compatibility w/ flatc generator.

Łukasz Kurowski · Answer 1 · Fri Nov 23 2018 18:58:12 GMT+0800 (China Standard Time)

what is the problem? ^^

Łukasz Kurowski · Answer 2 · Fri Nov 23 2018 21:08:34 GMT+0800 (China Standard Time)

I tested it with CMake

smfc_gen(
  GOLANG
  TARGET_NAME not_a_demo
  OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
  SOURCES not_a_demo.fbs)

Alexander Gallego · Answer 3 · Sun Nov 25 2018 07:38:52 GMT+0800 (China Standard Time)

so flatc/smfc should be the consistent. Even if it means consistently incorrect.

flatc generates one subdirectory per sub import in go.

i..e:
package foo.bar.baz

will create a folder in foo/bar/baz.go where baz.go will have package baz at the top.

Same w/ smfc.