smarteist / Android-Image-Slider

Android Auto Image Slider

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Animation constant names

dzboot02 opened this issue · comments

commented

Hi and thank you for this useful library, but you have to excuse for what I am about to say.

public enum SliderAnimations {
    ANTICLOCKSPINTRANSFORMATION,
    CLOCK_SPINTRANSFORMATION,
    CUBEINDEPTHTRANSFORMATION,
    CUBEINROTATIONTRANSFORMATION,
    CUBEINSCALINGTRANSFORMATION,
    CUBEOUTDEPTHTRANSFORMATION,
    CUBEOUTROTATIONTRANSFORMATION,
    CUBEOUTSCALINGTRANSFORMATION,
    DEPTHTRANSFORMATION,
    FADETRANSFORMATION,
    FANTRANSFORMATION,
    FIDGETSPINTRANSFORMATION,
    GATETRANSFORMATION,
    HINGETRANSFORMATION,
    HORIZONTALFLIPTRANSFORMATION,
    POPTRANSFORMATION,
    SIMPLETRANSFORMATION,
    SPINNERTRANSFORMATION,
    TOSSTRANSFORMATION,
    VERTICALFLIPTRANSFORMATION,
    VERTICALSHUTTRANSFORMATION,
    ZOOMOUTTRANSFORMATION
}

This is a crime against humanity, no one should ever name variable or constants like this. You gave me a headache just trying to read what does this means!

Also no documentation, no explanation.

Sorry, but this is too much.