Giters

smartcontractkit / full-blockchain-solidity-course-js

Learn Blockchain, Solidity, and Full Stack Web3 Development with Javascript

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Make a doc that has the solidity style guide + the Chainlink style guide

PatrickAlphaC opened this issue · comments

commented

Describe the enhancement

Make a PR to the chainlink github with the style guide officially laid out.

commented

How's this #434 ? Let me know if that needs some improvements or if you were thinking of something different altogether.

Also let me know if it's better I make a new PR since #434 is a bit of a mess. It has multiple commits cause I kept fixing the formatting. And it also has a typo fix for README.md

commented

Does this still have to be done? If so, where in Chainlink's GitHub should the PR be made? Cheers.

commented

Probably the chainlink core repo.

https://github.com/smartcontractkit/chainlink

I'd like someone from the Chainlink Labs org to do it though, to make sure the style is correct.

commented

Probably the chainlink core repo.

https://github.com/smartcontractkit/chainlink

I'd like someone from the Chainlink Labs org to do it though, to make sure the style is correct.

I see! Is it okay if I do one myself and make a PR there? Because that way, if necessary, it will be easier for someone from Chainlink Labs to verify/edit the guide. Cheers.