smartcontractkit / external-adapters-js

Monorepo containing JavaScript implementation of external adapters

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Etherscan adapter: missing new fields of Get Gas Oracle

aelmanaa opened this issue · comments

Hello,

the Get Gas Oracle has new fields suggestBaseFee and gasUsedRatio which are missing in the adapter.

Also, I've got a suggestion for the default behavior: Maybe we should return all the fields instead of returning only the fast one

const speed = speedType[speedValue] || speedType.fast

Hey @aelmanaa, finally getting around to responding to this - thanks for opening it.

We will update the response interface for those new types.

As for the default behavior, the EA usually wants to respond with a single value, unless the feeds job spec uses multi-word response.