Event listener is not removed

Question

Event listener is not removed

prepfarm opened this issue 6 months ago · comments

prepfarm commented 6 months ago

Bug Report

Prerequisites

[ x] Can you reproduce the problem in a MWE?
[ x] Are you running the latest version?
[x ] Did you perform a search in the issues?

Environment Details and Version

piral 1.3.3
net7.0 with Piral.Blazor packages are 7.0.10-pre.20231128.2

Description

RemoveEventListener Is not actually removing event listener. Trying out this example inside of my project, is not getting removed and if component gets initialized again (go back and open the page again), number of logs always increases by one (I have added log inside of the ToggleSidebar method).

Expected behavior

Event listener to be removed.

Florian Rappl · Answer 1 · Mon Dec 11 2023 21:33:11 GMT+0800 (China Standard Time)

Are you sure that the dispose is called?

prepfarm · Answer 2 · Tue Dec 12 2023 00:37:52 GMT+0800 (China Standard Time)

Yes, I have added @implements IDisposable and log inside of Dispose method which gets called few seconds after navigating off that page.

Florian Rappl · Answer 3 · Tue Dec 12 2023 00:57:34 GMT+0800 (China Standard Time)

Alright thanks for the confirmation - I will look into it.

Florian Rappl · Answer 4 · Fri Dec 22 2023 18:30:22 GMT+0800 (China Standard Time)

This is fixed and will be part of v10.