Giters

smallrye / smallrye-common

Common utilities for SmallRye

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect error message for Assert.assertTrue and Assert.assertFalse

torinthiel opened this issue · comments

commented

smallrye-common/constraint/src/main/java/io/smallrye/common/constraint/Assert.java

Line 543 in 03ca57d

assert expr : Messages.log.expectedBoolean(expr);
and

smallrye-common/constraint/src/main/java/io/smallrye/common/constraint/Assert.java

Line 555 in 03ca57d

assert !expr : Messages.log.expectedBoolean(expr);
reference the error message with the current value of the argument. However the message in this case reads 'Internal error: Assertion failure: Expected boolean value to be %s', referencing the expected value. Thus a test of Assert.assertTrue(false) fails with confusing message 'Internal error: Assertion failure: Expected boolean value to be false'.