Move to SmallRye

Question

Move to SmallRye

Ladicek opened this issue 3 years ago · comments

For the 3.0 release, we want to move Jandex to SmallRye (and use the automated release process SmallRye has). Ideally, all Jandex repos (this one, the typeannotation-test, and the Maven plugin) would be brought into one (covered by #122).

The groupId would change from org.jboss[.jandex] to io.smallrye (or io.smallrye.jandex, but I'd probably prefer the first one :-) ). The artifactIds or packages wouldn't change (so packages would still be org.jboss.jandex), as that would be too big of a break.

EDIT: as part of this, also rename the master branch to main.

Darran Lofthouse · Answer 1 · Tue Jul 27 2021 17:49:30 GMT+0800 (China Standard Time)

I don't think everyone will get the individual notifications from GitHub, maybe worth forwarding to the wildfly-dev list?

Ladislav Thon · Answer 2 · Tue Jul 27 2021 17:57:54 GMT+0800 (China Standard Time)

I agree, but I also think we should do that after the 2.4.0.Final release. I mean -- what I just added to the 2.4.0.Final milestone was originally referred to as 3.0. Then we decided we should call it 2.4, as there's nothing breaking, and do a 3.0 with some breakages that are needed (including this one). I think that makes most sense, but until that is actually done, I'd like to leave the door open :-)

Darran Lofthouse · Answer 3 · Tue Jul 27 2021 20:48:45 GMT+0800 (China Standard Time)

+1 whenever makes more sense.

George Gastaldi · Answer 4 · Tue Aug 24 2021 04:43:36 GMT+0800 (China Standard Time)

@Ladicek moving to Smallrye sounds like a wonderful idea, +1 to that. About the package name, I wonder if that wouldn't be an opportunity to introduce some major API changes (eg. introduce a new API under io.smallrye.jandex and keep the original API under org.jboss.jandex)?

Ladislav Thon · Answer 5 · Tue Aug 24 2021 14:55:54 GMT+0800 (China Standard Time)

I'm not sure we want to have 2 APIs. Also current implementation relies heavily on package-private methods, which precludes such split. I think we'll just live with some breaking changes :-)

Ladislav Thon · Answer 6 · Fri Aug 27 2021 21:33:45 GMT+0800 (China Standard Time)

We should also consider publishing relocations (https://maven.apache.org/guides/mini/guide-relocation.html). I'm not sure it's worth it, but David says it is :-)

Ladislav Thon · Answer 7 · Tue Sep 07 2021 20:45:38 GMT+0800 (China Standard Time)

All the changes required in the code base (groupId and parent POM) are now done on the smallrye branch. I'm not closing this issue because Jandex is still under the wildfly org. I believe we should transfer this repo to the smallrye org when the 3.0 release is almost ready. In the meantime, the changes for the 3.0 release should be done as PRs against the smallrye branch.

Ladislav Thon · Answer 8 · Wed Jun 22 2022 23:13:26 GMT+0800 (China Standard Time)

I just moved the Jandex repository to the smallrye GitHub org in preparation for a 3.0.0-RC1 release. Hence this is done for good.