What happens ?
opened this issue · comments
Before the last iris was first with fasthttp-raw,
before 18 days, as this commit also says:
0874ce6.
Also I didn't change any performance-releated with SetBody & router, I just tested with a version we had before a month and the benchmark results are the same as the latest iris version.
Can you tell me when you upgraded iris? what version did you had before (or a date) you did several tests within this period, this is the first time iris is down.
And if you didn't changed anything(iris-releated) from the previous week, could you please re-run the tests?
Edit2:
I just ran the benchmarks from docker with docker pull smallnest/go-web-framework-benchmark docker run -v /opt/data:/data smallnest/go-web-framework-benchmark .
Iris is still side-by-side with fasthttp. Some other frameworks I saw on this repo's README that seems to be top of iris, in real, they have lowest results...
For now, only the basic tests (0ms 5000 clients) are finished:
I ran it from a 'clean/fresh' docker*
but on README's Basic tests are:
How is that even possible?
Edit 3: 10ms 5k clients finished also:
I will leave the machine open until the graphical results also... I really need to sleep now
But you got the idea.. something happened on your last machine's benchmark testing
Thanks for everything!!
I remove iris and run go get -u.
I started a new test.
Iris still is No. 1.
I update test results (pipeline has not updated yet because test has not been finished, I will update all test results tomorrow).
I think the reason is I have not updated latest web frameworks.
But i found that clevergo is missing, although it is not important for me, hope to add it next time. :) @smallnest
@headwindfly I don't know why clevergo has not been included in test results. Codes exist here. I will re-run the test and check the test result. Thanks.
@kataras I hope you to read the code of clevergo :)
I haven't seen the iris code, just found that the banner of iris is pretty, so i created one like this.
what is the reason make you think i copy your code? that make me confuse.(banner?)
of course, I very want to solve misunderstanding!
@kataras The rest controller inspire by beego.
http://beego.me/docs/mvc/controller/controller.md
@kataras
the original version of clevergo is here https://github.com/clevergo/clevergo, it based on net/http.
and i found the fasthttp package, and then rewrite it for fasthttp.
I thought my middleware , Context,csrf, jwt, session, captcha,etc is difference with your framework.
And it based on fasthttprouter and httprouter.
If you think I copied your code, please point out them. Thanks.
Anyway, Please do not post comments that lack of truth.
@kataras to be clear you need to remember that you've lied some time ago when you edited users' comments, issues etc. so if you think that we are all friends why you blame people?
@kirillDanshin you're on of Iris' fans, happy to see you here, your feature request is this provider: https://github.com/kataras/iris/issues/199
I didn't edit your comment, 'Bountysource ' github integration did that (which I removed before some days) ...anyway
@kataras no, I'm not about my own comments. I talking about other Iris' fans'/users' comments. about your committing policy: look, you merging PRs that way so nobody other can't be shown in contributors page. I agree that you've made huge work on creating cool framework but I can't understand your contributing policy, vendoring policy, existence of «propaganda» label and your issue editing.
@kirillDanshin Thanks. I found the real reason from your comment, so i drop iris. Use beego..