Subscribe() takes exactly 1 argument (2 given)

Question

Subscribe() takes exactly 1 argument (2 given)

bandroidx opened this issue 11 years ago · comments

I get this error on several different setups of Stratum in various miners every time a user joins the pool:

2013-04-10 07:20:16,353 ERROR protocol # [Failure instance: Traceback: <type 'exceptions.TypeError'>: subscribe() takes exactly 1 argument (2 given)
/opt/stratum/stratum/stratum/protocol.py:192:dataReceived
/opt/stratum/stratum/stratum/protocol.py:238:lineReceived
/opt/stratum/stratum/stratum/services.py:13:_handle_event
/opt/stratum/stratum/stratum/services.py:81:call
--- ---
/usr/lib/python2.7/dist-packages/twisted/internet/defer.py:134:maybeDeferred
/opt/stratum/stratum/stratum/services.py:78:_run
]
None

bandroidx commented 11 years ago

correct

Slush · Answer 1 · Wed Apr 10 2013 15:52:32 GMT+0800 (China Standard Time)

Are you trying to setup your own pool?

bandroidx · Answer 2 · Wed Apr 10 2013 21:48:00 GMT+0800 (China Standard Time)

The error happens for me even in bitcoin mode with the demo mining pool

Damien · Answer 3 · Thu May 23 2013 14:53:50 GMT+0800 (China Standard Time)

I am having the same error as bandroidx. Has there been any developments on this/is there a workaround?

Damien · Answer 4 · Thu May 23 2013 20:54:41 GMT+0800 (China Standard Time)

To get around this issue I did the following:

In protocol.py, after the following code:
msg_id = message.get('id', 0)
msg_method = message.get('method')
msg_params = message.get('params')
msg_result = message.get('result')
msg_error = message.get('error')

I added:
if msg_method == "mining.subscribe":
del msg_params[0:len(msg_params)]

This has resolved the error, and everything still seems to be mining fine. Is their any issues you can see with this? Any problems which may be caused which I haven't seen?

Thanks

Tyler Burleigh · Answer 5 · Fri May 24 2013 07:54:16 GMT+0800 (China Standard Time)

Thanks dshiells that worked for me!

Damien · Answer 6 · Fri May 24 2013 14:39:09 GMT+0800 (China Standard Time)

Thanks tylerburleigh!

As I mentioned it seems a bit of a hack though, so hoping for a response from slush to see it won't affect something down the line. I have posted here and in the relevant bitcointalk.org forum.

Glad it seems to work for you too though...

Daniel Morante · Answer 7 · Sun Nov 24 2013 09:22:21 GMT+0800 (China Standard Time)

Seems that this "extra" parameter is just a user agent string sent by the client.
A better "hack" could be to add the additional parameter in the subscribe method in mining/service.py:

def subscribe(self, useragent):
log.info("Subscribed: %s" % str(useragent))

Slush · Answer 8 · Mon Nov 25 2013 10:15:58 GMT+0800 (China Standard Time)

Actually this is bug of stratum-mining service, not in stratum library. I just fixed it in this commit: slush0/stratum-mining@8a7474e

Vito Tafuni · Answer 9 · Fri May 09 2014 02:31:38 GMT+0800 (China Standard Time)

I have the same problem in stratum-mining-proxy...