Can we use dos2unix instead own implementation here

Question

Can we use dos2unix instead own implementation here

markusweigelt opened this issue 2 years ago · comments

@bertsky https://github.com/markusweigelt/ocrd_manager/blob/668d2305525e6ad91e2b7b59891ec105d86b37af/for_production.sh#L72

Robert Sachunsky · Answer 1 · Thu Apr 07 2022 23:27:05 GMT+0800 (China Standard Time)

What do you mean dos2unix?

Markus Weigelt · Answer 2 · Thu Apr 07 2022 23:40:22 GMT+0800 (China Standard Time)

I suspected here that this replacement takes place to avoid certain windows characters but it is general and has nothing to do with it. :-/

I think since the workflows are written independently of the linux system it can come to problems at this point when CR LF newlines are not converted.

Robert Sachunsky · Answer 3 · Thu Apr 07 2022 23:50:19 GMT+0800 (China Standard Time)

I think since the workflows are written independently of the linux system it can come to problems at this point when CR LF newlines are not converted.

Yes, to make this compatible with the DOS/Windows EOL convention, you need #12