slimphp / Slim-Http

A set of PSR-7 object decorators providing useful convenience methods

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Possibility of removing final on constructors?

dlundgren opened this issue · comments

The following classes had constructors that were converted to final in #118, and it'd be nice to not have them final for those of us who are extending the classes, and modifying the constructors.

  • ServerRequest
  • Response
  • URI

I'm particularly interested in Response as I extend it to create a Redirect class that I use to more easily handle forwards (internal framework), and actual redirects.

Remove them and run static analysis, you’ll understand why we shouldn’t.