slimjs / slim.js

Fast & Robust Front-End Micro-framework based on modern standards

Home Page:http://slimjs.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect call to autoBoundAttributes.includes inside attributeChangedCallback prevents attribute-property syncing

yavuztor opened this issue · comments

When an attribute is set using element.setAttribute(..), its auto-bound property is not updated properly, due to an incorrect call for autoBoundProperties.includes.

if (newValue !== oldValue && this.autoBoundAttributes.includes[attr]) {

Since includes is a function, this.autoBoundAttributes.includes[attr] should be this.autoBoundAttributes.includes(attr)

great catch!
Would you pr?

Sure. I will get that soon.