slavcodev / coverage-monitor-action

A GitHub Action that monitor coverage.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Pipeline is failing when it throws a warning

GertjanRoke opened this issue · comments

I have a threshold_alert set to 0 and a threshold_warning set to 75 as you can see below, but for some reason the pipeline now fails instead of passing.

Now:
image

Yesterdag:
image

- name: Report coverage to Pull Request
   uses: slavcodev/coverage-monitor-action@v1
   if: ${{ github.event_name == 'pull_request' }}
   continue-on-error: true
   with:
      github_token: ${{ secrets.GITHUB_TOKEN }}
      coverage_path: coverage-clover.xml
      threshold_alert: 0
      threshold_warning: 75
      comment: false

Looks to be because of the last release, if you need more info please let me know, would love to help.

Just set threshold_alert to 1 and then it works fine, if this is expected then you can close this issue 😉

Nope, it's not expected, it's a bug.

Just fixed it in v1.4.1, should already work for you if you use generic version v1.

Thank you, @GertjanRoke