slav123 / CodeIgniter-minify

CodeIgniter minify library CSS and JavaScript compression on the fly

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Should only throw error on deploy

Goddard opened this issue · comments

I noticed in this library it throws an error early on even if the library doesn't need write access.

For example
get_instance()->load->library('minify');

It throws an error here or rather in the constructor which runs _config_checks().

It should only do the config checks if called on, or when about to actually do writing.

My situation it doesn't make sense to regenerate the file in production. It only makes sense to regenerate my css and js files in development and when I deploy completely shut off the generation because it just costs extra seconds that it doesn't need to waste.

I can make a pull request if you like, or am I missing something?

Thanks

It is true.
This is exactly my problem.

Let me know if it solves your problem

Looks good.