slav123 / CodeIgniter-minify

CodeIgniter minify library CSS and JavaScript compression on the fly

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Some casuistries not covered on JS

Proogresa opened this issue · comments

1

data: {
  customer_email: customer_email,
  customer_firstname: customer_firstname,
}

Last colon is an error, but jQuery skip that with no issue.
The minifier returns an empty script when it founds that.

2

When the minifier detects on the array of files a file modified after the last time, it generates the resulting script, it generates a new one. It rocks. But...
When you add to the array of files a new file wich its last modified date is previous to the resulting script modified date, it does not generates a new one.

about 1 - i'm using closure compiler to compress JS - don't have much input on that. i was thinkig about intruducing another JS compressor to chose from.

about 2 - correct, it's an issue

in latest release just introduced new js compression engines, so problem should be solved. stil not sure how to address second issue, without keeping some kind of metadata around builds