Question: Is queryf silently correcting mistakes considered a bug?
lexidor opened this issue · comments
Issue template for hack-sql-fake
Please select the options that apply
- Feature request
- Question
- Suggestion
- Typechecker errors
- Incorrect result
- Cripplingly bad performance
- Crash
Follow the template for your checked checkbox and then delete the templates.
Question
Would it be considered a bug if the queryf implementation of SQL Fake silently "corrects" errors which cause the real queryf to throw? A lot of strict validation is missing from the SQL Fake implementation and I would love to make it as strict as the real queryf. For example SELECT "hi" throws in the real queryf.
I would love to submit a PR aligning queryf with queryf. This would break BC left, right, and center. But I believe this would be for the better. Would this be appreciated?
Yes, I would like the library to be as strict as Hack's implementation, would definitely welcome PRs fixing this!
Alright, I'll submit a PR that enforces Hack's rules.