AsyncMysqlQueryResult::mapRows() returns NULL as ""

Question

lexidor opened this issue 5 years ago · comments

This line makes all the return values strings, even the NULL values. https://github.com/slackhq/hack-sql-fake/blob/master/src/AsyncMysql/AsyncMysqlQueryResult.php#L42
According to the documentation the return type should be Vector<Map<string, string>>, but that seems off. The HHI agrees with that too. However the documentation describes string|null.
https://docs.hhvm.com/hack/reference/class/AsyncMysqlQueryResult/mapRows/#examples

Are we sure the return type isn't secretly Map<string, ?string>?

Scott Sandler · Answer 1 · Wed Jul 24 2019 08:32:42 GMT+0800 (China Standard Time)

You're right! It should be nullable, I am able to get null results back from mapRows().

I'd advise using mapRowsTyped() if possible but we should still fix this to match the real behavior despite the HHI

Lexidor Digital · Answer 2 · Wed Jul 24 2019 08:34:32 GMT+0800 (China Standard Time)

I'll open a bug report on the offending HHI.

Lexidor Digital · Answer 3 · Wed Jul 24 2019 08:47:54 GMT+0800 (China Standard Time)

The HHI may very soon match the runtime behavior. facebook/hhvm#8540

Scott Sandler · Answer 4 · Thu Jul 25 2019 22:29:04 GMT+0800 (China Standard Time)

Thank you for fixing! #20