skytable / skytable

Skytable is a modern scalable NoSQL database with BlueQL, designed for performance, scalability and flexibility. Skytable gives you spaces, models, data types, complex collections and more to build powerful experiences

Home Page:https://skytable.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Internal: Upgrade to clap 4.0 or 3.0

ohsayan opened this issue · comments

commented

We're still on the 2.x release of clap, and the current major version of clap is 4.0. The reason we skipped the 3.0 update was because support for yaml files was removed in favor of a derive-based API. Although this is trivial to rewrite in the case of the other binaries, it isn't an entirely simple task in the case of the skyd binary because the config module relied on a lot of machinery that clap 2.x supported. Although I believe I did raise this with clap's team and they rolled out a release with support for the library fns that we needed, we haven't had a chance to upgrade since then. If someone wants to help upgrade the code, I'll be happy to mentor, else I'll do it later when I have the time.

Progress on upgrades:

Hey @ohsayan , happy to lend a hand with this one - Discord a good place to talk about this?

commented

Hey @ohsayan , happy to lend a hand with this one - Discord a good place to talk about this?

Please drop by Discord and we can discuss this. Thanks!

commented

@sanjayts Has has been working on this across #284, #285 and #286 ❤️