com.xerox.amazonws.sqs2.QueueAttribute

Question

com.xerox.amazonws.sqs2.QueueAttribute

xbranko opened this issue 11 years ago · comments

This class is from typica's jar. Any chance to leave it out of your jar? You added QUEUE_ARN enum value that is not originally there. Typica's version doesn't have this, but TypicaSQSQueue.getQueueAttributes(QueueAttribute) needs a QueueAttribute -- so I see why it needed to be done somehow. Given that TypicaSQSQueue is deprecated, and QUEUE_ARN enum value is used only there, any chance it may be dropped in favor of amazonaws classes?

Carter Page · Answer 1 · Wed Jan 08 2014 06:41:58 GMT+0800 (China Standard Time)

We'll remove it entirely when we do a major release. How is it causing your problems right now?

xbranko · Answer 2 · Wed Jan 08 2014 06:54:21 GMT+0800 (China Standard Time)

In my company's centralized build environment there is a rule that no two jars can have the same class. Given that we already have typica, I cannot add nevado (because of com.xerox.amazonws.sqs2.QueueAttribute).

Carter Page · Answer 3 · Wed Jan 08 2014 22:57:19 GMT+0800 (China Standard Time)

Oh I see, you're talking about the override within Nevado, not the Typica
dependency. Let me see what I can do.
On Tue Jan 07 2014 at 5:55:25 PM, xbranko notifications@github.com wrote:

In my company's centralized build environment there is a rule that no two
jars can have the same class. Given that we already have typica, I cannot
add nevado (because of com.xerox.amazonws.sqs2.QueueAttribute).

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/70#issuecomment-31788838
.

Carter Page · Answer 4 · Wed Jan 08 2014 23:08:47 GMT+0800 (China Standard Time)

I'm looking at it, and it won't be super-straightforward. I can't simply remove Typica with a patch release. Some users depend on it. I can look at other ways to refactor to get rid of the override (which I always found annoying besides). Or maybe I can talk the Typica author into updating his enum.

xbranko · Answer 5 · Thu Jan 09 2014 00:38:32 GMT+0800 (China Standard Time)

I understand. It might be hard to get typica update, the last release was 1.7.2. in July 2010. I wonder if it is an active project still. You mentioned a major release -- what is the time frame for that? Any chance of bringing it forward?

Carter Page · Answer 6 · Thu Jan 09 2014 01:19:55 GMT+0800 (China Standard Time)

I don't have one scheduled. Maybe I'll remove it in a 1.3.0 release if I
can't get a response from the Typica dev.

On Wed Jan 08 2014 at 11:38:36 AM, xbranko notifications@github.com wrote:

I understand. It might be hard to get typica update, the last release was
1.7.2. in July 2010. I wonder if it is an active project still. You
mentioned a major release -- what is the time frame for that? Any chance of
bringing it forward?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/70#issuecomment-31851335
.

Carter Page · Answer 7 · Mon Jan 13 2014 03:18:49 GMT+0800 (China Standard Time)

I've cut a 1.3.0 release with Typica removed. It is available for download now at https://github.com/skyscreamer/nevado/releases. It will appear on Maven repositories everywhere by the end of the week.

Thanks for reporting the issue.

xbranko · Answer 8 · Tue Jan 14 2014 02:53:41 GMT+0800 (China Standard Time)

Thanks for the quick release! Really appreciate it! You might want to remove the comment referencing Typica too (In Readme.md file ).

Carter Page · Answer 9 · Tue Jan 14 2014 03:18:46 GMT+0800 (China Standard Time)

Good catch, thanks!

On Mon Jan 13 2014 at 1:53:52 PM, xbranko notifications@github.com wrote:

Thanks for the quick release! Really appreciate it! You might want to
remove the comment referencing Typica too (In Readme.md file ).

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/70#issuecomment-32198713
.