Provide skyline in alternative package name
javithakthar opened this issue · comments
Currently skyline is not identified as "game" with some OEM game launcher applications (e.g, samsung game launcher) so we cannot use game specific optimizations (such as pause USB power delivery).
It would be helpful if skyline is provided in alternative package name like com.miHoYo.GenshinImpact.
I think this would be a great idea! Also potentially a high-performance build that uses a package name of a benchmark. I know Dolphin MMJ has an antutu package name version. This kills battery life but significantly enhances performance. I think this could be beneficial for performance, especially for devices like the S23 Ultra, which have different normal application, game, and benchmark performance profiles.
It has nothing to do with the package name. e63108b marked the app as a game on the emulator side. Samsung's Game Launcher only recognizes apps that are hosted on Google Play. You can, however, manually add it to the list.
No it doesn't work if manually add the game. That's why raising this issue.
Please try it once yourself before copy pasting stuffs from internet. The launcher will technically allows to add any apps to game launcher. But it'll not activate game mode related features. You'll get tost notification like "skyline is not a game. So some features will not work with it".
Basically it allows you to launch an app but doesn't apply any game booster related stufs.
I understand you are frustrated, but the issue isn't with Skyline and isn't even with Game Launcher. What seems to have been taken as a completely random paste from the internet was actually an explanation of why the app is not identified as "game" with some OEM game launcher applications (e.g, samsung game launcher)
https://www.samsung.com/us/support/answer/ANS00079059/
Game Booster is a separate app from Game Launcher, but the two of them work together. Game Booster is a handy menu that appears when you're playing a game and provides helpful tools, so you can get the best performance and play on without interruptions.
Samsung chooses which apps are identified by Game Booster internally and does not provide that information to developers. The reason is also not given, but it's likely to prevent abuse. You could always contact Samsung and see if they will help you get it added.
My original request still stands valid. I've raised this issue for tracking such. This issue can be marked as closed if devs are not planning to do this any time in near future. Other emus like Citra mmj provides in alternate package names so that the system treats as benchmarking/known games and applies optimization as needed.
The MMJ versions of Citra, Dolphin, etc are unofficial builds by a private developer. That's why you don't see Citra or Dolphin spoofing the package names of another game, only the modified version.
Can confirm that we don't plan to do this, official Skyline package names will be retained for the foreseeable future. We already achieve a similar effect with the "Force Maximum GPU Clocks" option that uses KGSL IOCTLs to force the GPU to maximum clocks on Adreno devices. Additionally, we plan to add support for OS level performance APIs such as Qualcomm's Performance SDK which can give us control over CPU clocks on supported devices so we can achieve complete parity with the vendor solutions while retaining proper package names.